Skip to content

fix: rootKey empty check by len equals 0#801

Merged
tac0turtle merged 4 commits intocosmos:masterfrom
mmsqe:fix_iterator
Aug 7, 2023
Merged

fix: rootKey empty check by len equals 0#801
tac0turtle merged 4 commits intocosmos:masterfrom
mmsqe:fix_iterator

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 27, 2023

this change should not have been included in e46665c

@mmsqe mmsqe marked this pull request as ready for review July 27, 2023 13:06
@mmsqe mmsqe requested a review from a team July 27, 2023 13:06
@tac0turtle tac0turtle merged commit 06f5be1 into cosmos:master Aug 7, 2023
@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 8, 2023

@tac0turtle Is it possible that we backport this to v0.20.x?

@tac0turtle
Copy link
Contributor

tac0turtle commented Aug 8, 2023

@tac0turtle Is it possible that we backport this to v0.20.x?

i dont see this being part of v0.20. I might be looking the wrong place, are you able to see it?

@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 8, 2023

@tac0turtle Is it possible that we backport this to v0.20.x?

i dont see this being part of v0.20. I might be looking the wrong place, are you able to see it?

Yes, https://github.com/cosmos/iavl/blob/release/v0.20.x/iterator.go#L272

mmsqe added a commit to mmsqe/iavl that referenced this pull request Aug 10, 2023
@mmsqe @tac0turtle
fix: rootKey empty check by len equals 0 (cosmos#801)
21073c8 
Co-authored-by: Marko <marbar3778@yahoo.com>
@julienrbrt
Copy link
Contributor

julienrbrt commented Aug 10, 2023 •
edited
Loading

If this gets backported in v0.20, we should backport it in v1.0.0 and v0.21 as well.

@julienrbrt
Copy link
Contributor

julienrbrt commented Aug 10, 2023

@Mergifyio backport release/v1.x.x

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023 •
edited
Loading

backport release/v1.x.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Aug 10, 2023
@mmsqe @mergify
fix: rootKey empty check by len equals 0 (#801)
9c9eee2 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 06f5be1)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 10, 2023
Merged
@tac0turtle
Copy link
Contributor

tac0turtle commented Aug 10, 2023

@Mergifyio backport release v0.20.x

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

backport release v0.20.x

❌ No backport have been created

Details
  • Backport to branch release failed

GitHub error: Branch not found

  • Backport to branch v0.20.x failed

GitHub error: Branch not found

@tac0turtle
Copy link
Contributor

tac0turtle commented Aug 10, 2023

@Mergifyio backport release/v0.20.x

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023 •
edited
Loading

backport release/v0.20.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Aug 10, 2023
@mmsqe @mergify
fix: rootKey empty check by len equals 0 (#801)
a802999 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 06f5be1)

# Conflicts:
#	CHANGELOG.md
#	iterator_test.go
@mergify mergify bot mentioned this pull request Aug 10, 2023
Closed
@julienrbrt
Copy link
Contributor

julienrbrt commented Aug 10, 2023

@Mergifyio backport release/v0.21.x

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023 •
edited
Loading

backport release/v0.21.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Aug 10, 2023
@mmsqe @mergify
fix: rootKey empty check by len equals 0 (#801)
bddaff9 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 06f5be1)

# Conflicts:
#	CHANGELOG.md
#	iterator.go
#	iterator_test.go
@mergify mergify bot mentioned this pull request Aug 10, 2023
Closed
julienrbrt added a commit that referenced this pull request Aug 10, 2023
@mergify @mmsqe @julienrbrt
fix: rootKey empty check by len equals 0 (backport #801) (#809)
78072ce 
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt pushed a commit that referenced this pull request Aug 10, 2023
@mmsqe @tac0turtle
fix: rootKey empty check by len equals 0 (backport: #801) (#808)
b35e4ff 
Co-authored-by: Marko <marbar3778@yahoo.com>
@coderabbitai coderabbitai bot mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cool-develope cool-develope cool-develope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cool-develope cool-develope

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmsqe @tac0turtle @julienrbrt @cool-develope