Merged
Conversation
julienrbrt
approved these changes
Apr 12, 2023
Contributor
julienrbrt
left a comment
There was a problem hiding this comment.
lgtm! We probably need a changelog that mentions the api break.
julienrbrt
reviewed
Apr 12, 2023
cool-develope
approved these changes
Apr 12, 2023
Contributor
Author
|
@Mergifyio backport release/v1.x.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
(cherry picked from commit 85a123c) # Conflicts: # export_test.go # go.mod # go.sum # internal/logger/logger.go
tac0turtle
added a commit
that referenced
this pull request
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace local logger with sdk one, this help sin the future when we add logs to the repo. We should avoid adding info logs here and mainly to error and debug if possible