test: run slow tests without race detector in CI#338
Merged
erikgrinaker merged 6 commits intomasterfrom Nov 23, 2020
Merged
Conversation
tac0turtle
approved these changes
Nov 23, 2020
Contributor
Author
|
Well, that didn't really help much. Locally I'm seeing 70-90% reductions in test time, but then I also have an 8-core machine. GitHub actions uses 2 cores, I think. Will try using default parallelism (2) in case the additional jobs just cause more overhead. |
tac0turtle
reviewed
Nov 23, 2020
| for i, seed := range seeds { | ||
| i, seed := i, seed | ||
| t.Run(fmt.Sprintf("Seed %v", seed), func(t *testing.T) { | ||
| if testing.Short() && i >= 2 { |
Contributor
There was a problem hiding this comment.
Just a smile for going with shortening the amount of test cases.
Contributor
Author
|
Got it down to <4 minutes by reducing the number of large tests with the race detector enabled, and instead run larger data sets without race detector. E.g. we run two |
tac0turtle
approved these changes
Nov 23, 2020
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
looks good to me. Thank you for taking the time to make this go faster.
Contributor
Author
|
Superseded by #338. |
erikgrinaker
added a commit
that referenced
this pull request
Nov 23, 2020
KamiD
added a commit
to okblockchainlab/iavl
that referenced
this pull request
Apr 10, 2021
* fix: constant overflow when compiling for 32bit machines (cosmos#318) on Go 1.x(x) all constants are ints by default which causing build for 32bit machines to fail due to overflow golang/go#23086 Signed-off-by: Artur Troian <troian.ap@gmail.com> * changelog: release 0.14.2 * lint: update golangci-lint to 1.29 (cosmos#297) * ci: freeze golangci action version (cosmos#303) * github: bump golangci-lint and fix linter issues (cosmos#325) * test: check stray database entries in TestRandomOperations (cosmos#326) Checks that we don't leave behind any junk in the database, as reported in cosmos#324. * revert Protobuf methods accidentally cherry-picked in a41e36b * go.mod: bump tm-db to 0.5.2 * fix DeleteVersions stray orphans, and add DeleteVersionsRange (cosmos#324) * test: add TestRandomOperations case for DeleteVersions * test: run slow tests without race detector in CI (cosmos#338) * changelog: release 0.14.3 (cosmos#333) Co-authored-by: Artur Troian <troian@users.noreply.github.com> Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Klimov Sergey <klim0v-sergey@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.