This repository was archived by the owner on Nov 30, 2021. It is now read-only.
fix error of timeout when using Truffle to deploy contract#768
Merged
araskachoi merged 13 commits intocosmos:developmentfrom Feb 8, 2021
Merged
fix error of timeout when using Truffle to deploy contract#768araskachoi merged 13 commits intocosmos:developmentfrom
araskachoi merged 13 commits intocosmos:developmentfrom
Conversation
evm: reset cache after csdb is committed (cosmos#676)
update development
update development
update development
update development branch
update branch
update development
rpc: fix method to calculate block hash and fix mismatch block hash i…
araskachoi
previously approved these changes
Feb 5, 2021
araskachoi
reviewed
Feb 5, 2021
| } | ||
| // TODO: Remove gas usage calculation if saving gasUsed per block | ||
| gasUsed.Add(gasUsed, ethTx.Fee()) | ||
| gasUsed.Add(gasUsed, big.NewInt(int64(ethTx.GetGas()))) |
Contributor
There was a problem hiding this comment.
GetGas() just gives the gas limit correct?
would it be better to use:
gasUsed.Add(gasUsed, ethTx.Fee().Int64())
Author
There was a problem hiding this comment.
I think here need return gas used, not gas fee used, also, the number of Fee() is too big to return to the interface of web3.js, that will be crashed in web3.js lib cause too large number transform
Author
There was a problem hiding this comment.
ethTx.Fee() return gaslimit * gasPrice, its much larger than real number of gas costed
araskachoi
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #767
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)