Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Fix metamask pending while sending an error transaction#711

Merged
fedekunze merged 7 commits intocosmos:developmentfrom
KamiD:fix-mm-pending
Jan 18, 2021
Merged

Fix metamask pending while sending an error transaction#711
fedekunze merged 7 commits intocosmos:developmentfrom
KamiD:fix-mm-pending

Conversation

@KamiD
Copy link

@KamiD KamiD commented Jan 13, 2021

Closes: #710

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@KamiD KamiD changed the title Fix mm pending Fix metamask pending while sending an error transaction Jan 14, 2021
@fedekunze fedekunze merged commit cfe629c into cosmos:development Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metamask wallet will keep pending and failed to cancel the transaction when we sending an error tx

2 participants