This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Merged
Conversation
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
noot
reviewed
Jan 5, 2021
x/evm/types/genesis.go
Outdated
| } | ||
| if ga.Code != nil && len(ga.Code) == 0 { | ||
| return errors.New("code bytes cannot be empty") | ||
| if ga.Code == "" || len(ethcmn.Hex2Bytes(ga.Code)) == 0 { |
Contributor
There was a problem hiding this comment.
either one, I think if one is satisfied then the other always is
Comment on lines
+8
to
+9
| type Recipient struct { | ||
| Address string |
Contributor
There was a problem hiding this comment.
why is this no longer an address?
| AccountNonce uint64 | ||
| Price *big.Int `json:"gasPrice"` | ||
| GasLimit uint64 `json:"gas"` | ||
| Recipient *ethcmn.Address `json:"to" rlp:"nil"` // nil means contract creation |
Contributor
There was a problem hiding this comment.
can we just use *ethcmn.Address as the recipient type in the msg?
Contributor
Author
There was a problem hiding this comment.
no, because of the proto types we need to use string, and you can't take a string pointer on protobuf, so we need to wrap it on this Recipient struct
Comment on lines
+282
to
+284
| V *big.Int `json:"v"` | ||
| R *big.Int `json:"r"` | ||
| S *big.Int `json:"s"` |
Contributor
There was a problem hiding this comment.
same for these, why are these now []byte in the msg?
Contributor
Author
There was a problem hiding this comment.
there's no big.Int on protobuf
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 5, 2021
araskachoi
reviewed
Jan 6, 2021
noot
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual split of changes from #546. This PR updates struct types to the ones that will be defined on the proto files
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)