Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Stargate#546

Closed
fedekunze wants to merge 100 commits intofedekunze/stargate-8from
stargate
Closed

Stargate#546
fedekunze wants to merge 100 commits intofedekunze/stargate-8from
stargate

Conversation

@fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Sep 28, 2020 •
edited
Loading

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze self-assigned this Sep 30, 2020
fedekunze and others added 13 commits September 30, 2020 13:22
@fedekunze
Merge branch 'development' of github.com:ChainSafe/ethermint into rc0…
3b78044 
…/v0.2.1
@fedekunze
update changelog
42cd419
@fedekunze
crypto: refactor for stargate
9e6f38e
@fedekunze
Merge branch 'development' of github.com:ChainSafe/ethermint into cry…
9196272 
…pto-refactor
@fedekunze
fixes
c82547d
@fedekunze
fix keys
e0f70db
@fedekunze
Merge branch 'changelog' of github.com:ChainSafe/ethermint into crypt…
56d67cd 
…o-refactor
@fedekunze
changelog
eaa1f4c
@fedekunze
Merge branch 'development' into crypto-refactor
ce4160d
@fedekunze
conflicts
8a3121f
@fedekunze
crypto refactor changes
d15e36c
@fedekunze
Stargate 8 (#568)
1420a51 
* stargate 2

* fix imports

* stargate 3

* update export

* proto tools

* commands fixes

* rename client context

* remove client binary

* revert script changes

* update ethermintd

* fixes

* fixes

* update account

* more updates

* third party proto files

* move proto-files
:

* fix crypto

* account proto

* keys

* update testnet command

* evm proto

* genesis state proto

* messages
@fedekunze
more fixes
0daf3a4
@fedekunze fedekunze changed the title Stargate 1 Stargate Oct 9, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2021

This pull request introduces 1 alert when merging 36b85ad into 52d6d71 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2021

This pull request introduces 1 alert when merging 08c93c6 into 9ecd264 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@fedekunze fedekunze changed the base branch from development to fedekunze/stargate-8 January 11, 2021 15:44
@lgtm-com
Copy link

lgtm-com bot commented Jan 30, 2021

This pull request fixes 1 alert when merging 5884ba0 into 02ea658 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 30, 2021

This pull request fixes 1 alert when merging e16081f into 02ea658 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@freddyli7
Stargate binary fix (#784)
bf2f2aa 
* fixed invalid chainID, subscribe nil pointer dereference and empty keyring issue

* add keyring flag in start cmd

* update init script

* add amount back in `gentx` cli
@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2021

This pull request fixes 1 alert when merging bf2f2aa into 02ea658 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@araskachoi
add cmd flag for rpc api modules - stargate (#825)
8348e32 
* push changes to cmd for rpcapi options

* add flag parse in server file

* fix lint
@araskachoi
Update rpcapi changelog (#844)
8c30756 
* update changelog
@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2021

This pull request fixes 1 alert when merging 8c30756 into 02ea658 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@github-actions
Copy link

github-actions bot commented Apr 27, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Apr 27, 2021
@github-actions github-actions bot closed this May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@fedekunze fedekunze

Labels

stale stale PRs that will be closed if no further action occurs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fedekunze @chengwenxi @freddyli7 @araskachoi