Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

add cmd flag for rpc api modules - stargate#825

Merged
araskachoi merged 4 commits intostargatefrom
araska/stargate-rpcapi
Mar 12, 2021
Merged

add cmd flag for rpc api modules - stargate#825
araskachoi merged 4 commits intostargatefrom
araska/stargate-rpcapi

Conversation

@araskachoi
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@araskachoi
Copy link
Contributor Author

Someone remind me to add + edit the changelog before merging!

@araskachoi araskachoi removed the request for review from fedekunze March 12, 2021 20:02
@araskachoi araskachoi merged commit 8348e32 into stargate Mar 12, 2021
@araskachoi araskachoi deleted the araska/stargate-rpcapi branch March 12, 2021 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants