Add API.last_error#55
Merged
Merged
Conversation
ed3d898 to
5b25c3d
Compare
Because Ruby may call Win32 API and reset the error code before a user calls GetLastError(), the user might not be able to correct error code. To avoid it win32-api should store last error code like FFI or Fiddle do it. FYI: * FFI::LastError.winapi_error https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-class_method * Fiddle.win32_last_error https://rubyapi.org/3.0/o/fiddle#method-c-win32_last_error Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
Because these Rubies does not communicates with rubygems via HTTPS. This is SSL certificates expirations. And they are already EOL. Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
cosmo0920
approved these changes
Apr 17, 2021
cosmo0920
left a comment
Owner
There was a problem hiding this comment.
I'd tweaked for AppVeyor CI tasks. Yeah, adding last_error singleton method is reasonable for me. 👍 Thanks for your work!
This was referenced Apr 17, 2021
Merged
ashie
added a commit
to ashie/fluentd
that referenced
this pull request
Apr 19, 2021
WindowsFile calls GetLastError via win32-api to retrieve win32 error code but the error code may be already reset by Ruby's internal code so that it can't retrive a correct error code. Sometimes it causes random unrecoverable errors when in_tail plugin tries to read a non-existent file like the following: 2021-04-14 03:15:45 +0000 [error]: #2 Fluent::Win32Error code: 158, The segment is already unlocked.: C:/path/to/log.txt Fiddle or FFI has a method to avoid this issue: * Fiddle.win32_last_error https://ruby-doc.org/stdlib-3.0.0/libdoc/fiddle/rdoc/Fiddle.html#method-c-win32_last_error * FFI::LastError.winapi_error https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-instance_method We've added an equivalent method for win32-api: cosmo0920/win32-api#55 This commit replaces the retrieving the error code by using it. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
added a commit
to ashie/fluentd
that referenced
this pull request
Apr 19, 2021
WindowsFile calls GetLastError via win32-api to retrieve win32 error code but the error code may be already reset by Ruby's internal code so that it can't retrive a correct error code. Sometimes it causes random unrecoverable errors when in_tail plugin tries to read a non-existent file like the following: 2021-04-14 03:15:45 +0000 [error]: #2 Fluent::Win32Error code: 158, The segment is already unlocked.: C:/path/to/log.txt Fiddle or FFI has a method to avoid this issue: * Fiddle.win32_last_error https://ruby-doc.org/stdlib-3.0.0/libdoc/fiddle/rdoc/Fiddle.html#method-c-win32_last_error * FFI::LastError.winapi_error https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-instance_method We've added an equivalent method for win32-api: cosmo0920/win32-api#55 This commit replaces the retrieving the error code by using it. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
added a commit
to ashie/fluentd
that referenced
this pull request
Apr 19, 2021
WindowsFile calls GetLastError via win32-api to retrieve win32 error code but the error code may be already reset by Ruby's internal code so that it can't retrive a correct error code. Sometimes it causes random unrecoverable errors when in_tail plugin tries to read a non-existent file like the following: 2021-04-14 03:15:45 +0000 [error]: #2 Fluent::Win32Error code: 158, The segment is already unlocked.: C:/path/to/log.txt Fiddle or FFI has a method to avoid this issue: * Fiddle.win32_last_error https://ruby-doc.org/stdlib-3.0.0/libdoc/fiddle/rdoc/Fiddle.html#method-c-win32_last_error * FFI::LastError.winapi_error https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-instance_method We've added an equivalent method for win32-api: cosmo0920/win32-api#55 This commit replaces the retrieving the error code with this method. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
kenhys
pushed a commit
to kenhys/fluentd
that referenced
this pull request
Apr 22, 2021
WindowsFile calls GetLastError via win32-api to retrieve win32 error code but the error code may be already reset by Ruby's internal code so that it can't retrive a correct error code. Sometimes it causes random unrecoverable errors when in_tail plugin tries to read a non-existent file like the following: 2021-04-14 03:15:45 +0000 [error]: #2 Fluent::Win32Error code: 158, The segment is already unlocked.: C:/path/to/log.txt Fiddle or FFI has a method to avoid this issue: * Fiddle.win32_last_error https://ruby-doc.org/stdlib-3.0.0/libdoc/fiddle/rdoc/Fiddle.html#method-c-win32_last_error * FFI::LastError.winapi_error https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-instance_method We've added an equivalent method for win32-api: cosmo0920/win32-api#55 This commit replaces the retrieving the error code with this method. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Ruby may call Win32 API and reset the error code before a user
calls GetLastError(), the user might not be able to correct error code.
To avoid it win32-api should store last error code like FFI or Fiddle
do it. FYI:
https://www.rubydoc.info/github/ffi/ffi/FFI/LastError#winapi_error-class_method
https://rubyapi.org/3.0/o/fiddle#method-c-win32_last_error
Signed-off-by: Takuro Ashie ashie@clear-code.com