fix: upgrade toolkit-lib and use stack displayName #134
Merged
Conversation
This upgrades toolkit-lib to the latest version which fixes the libCheck typechecking. In the latest version toolkit-lib also updates the diff to use the stack display name instead of the name/id so this updates the action to also use the display name.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades toolkit-lib and refactors the code to use the stack display name instead of the name/id, while also switching from yarn to npm for dependency management.
- Upgrade toolkit-lib and related dependencies in package.json
- Update stack name handling in assembly and test files to use displayName
- Migrate package manager commands from yarn to npm in projen configuration and workflow files
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.dev.json | Removed skipLibCheck to leverage improved libCheck typechecking |
| test/stage-processor.test.ts | Updated displayName usage in test assertions and removed an unnecessary type cast |
| test/assembly.test.ts | Adjusted manifest keys and stack names to align with the new displayName format |
| src/assembly.ts | Switched to using stack.displayName to determine the stack name |
| package.json | Upgraded @aws-cdk/toolkit-lib and other dependencies |
| .projenrc.ts | Added explicit package manager setting and removed skipLibCheck comments |
| .projen/tasks.json | Replaced yarn commands with corresponding npm commands |
| .github/workflows/*.yml | Updated dependency installation commands to npm |
| .gitattributes | Added package-lock.json and removed yarn.lock entry |
Comments suppressed due to low confidence (2)
test/stage-processor.test.ts:115
- Removal of the type assertion might lead to type errors if stageComments is not publicly accessible; please verify that this change aligns with the type safety requirements of the project.
const p = processor.stageComments;
test/stage-processor.test.ts:566
- Ensure that changing the stack's internal name from the previous format is consistent with displayName usage across the project and does not break external references.
name: `my-stack${i}`,
rantoniuk
added a commit
to rantoniuk/corymhall-cdk-diff-action
that referenced
this pull request
Jun 2, 2025
* v2-beta: fix: process longer comments (corymhall#137) fix: upgrade toolkit-lib and use stack displayName (corymhall#134)
corymhall
added a commit
that referenced
this pull request
Jun 20, 2025
This upgrades toolkit-lib to the latest version which fixes the libCheck typechecking. In the latest version toolkit-lib also updates the diff to use the stack display name instead of the name/id so this updates the action to also use the display name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades toolkit-lib to the latest version which fixes the libCheck
typechecking. In the latest version toolkit-lib also updates the diff to
use the stack display name instead of the name/id so this updates the
action to also use the display name.