tests: stty: add require_controlling_input_terminal_ to bad-speed test #160
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bad-speed test runs 'stty ispeed 9600' without a --file argument, which requires a controlling terminal. Without it, stty fails early with 'Inappropriate ioctl for device' before reaching cfsetispeed, causing the test to skip with a misleading 'LD_PRELOAD interception failed' message. Add require_controlling_input_terminal_ to match the other stty tests (stty.sh, stty-pairs.sh, stty-row-col.sh, stty-invalid.sh) which all require a controlling terminal.
Member
|
pushed at e1994cd9a |
hubot
pushed a commit
that referenced
this pull request
Jan 5, 2026
The bad-speed test runs 'stty ispeed 9600' without a --file argument, which requires a controlling terminal. Without it, stty fails early with 'Inappropriate ioctl for device' before reaching cfsetispeed, causing the test to skip with a misleading 'LD_PRELOAD interception failed' message. * tests/stty/bad-speed.sh: Add require_controlling_input_terminal_ to match the other stty tests (stty.sh, stty-pairs.sh, stty-row-col.sh, stty-invalid.sh) which all require a controlling terminal. From #160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bad-speed test runs
stty ispeed 9600without a--fileargument, which requires a controlling terminal. Without it, stty fails early with "Inappropriate ioctl for device" before reaching cfsetispeed, causing the test to skip with a misleading "LD_PRELOAD interception failed" message.Add
require_controlling_input_terminal_to match the other stty tests (stty.sh, stty-pairs.sh, stty-row-col.sh, stty-invalid.sh) which all require a controlling terminal.