This repository was archived by the owner on Feb 5, 2020. It is now read-only.
*: remove k8s-node-bootstrap.service#3275
Merged
squat merged 1 commit intocoreos:masterfrom Jun 11, 2018
crawford:bootstrap
Merged
*: remove k8s-node-bootstrap.service#3275squat merged 1 commit intocoreos:masterfrom crawford:bootstrap
squat merged 1 commit intocoreos:masterfrom
crawford:bootstrap
Conversation
This was broken by 4f8f4fc when the origin image was used instead. The k8s-node-bootstrap service was failing to parse "latest" as valid semver. Since we are eventually moving away from Container Linux, this service is safe to remove in favor of some future mechanism.
|
Can one of the admins verify this patch? |
squat
approved these changes
Jun 11, 2018
Contributor
|
😿 |
Contributor
|
ok to test |
enxebre
approved these changes
Jun 11, 2018
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 6, 2018
These should have been removed by 45fa0e4 (*: remove k8s-node-bootstrap.service, 2018-06-08, coreos/tectonic-installer#3275).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken by 4f8f4fc when the origin image was used instead. The
k8s-node-bootstrap service was failing to parse "latest" as valid
semver. Since we are eventually moving away from Container Linux, this
service is safe to remove in favor of some future mechanism.