providers/vmware: add support for config encoding#191
Merged
crawford merged 2 commits intocoreos:masterfrom Mar 17, 2016
Merged
providers/vmware: add support for config encoding#191crawford merged 2 commits intocoreos:masterfrom
crawford merged 2 commits intocoreos:masterfrom
Conversation
This is needed to properly decode cloud-configs, which this needs to recognize and ignore. While we are at it, we might as well add encoding support for Ignition configs as well.
| case "gz", "gzip": | ||
| return decodeGzipData(data) | ||
|
|
||
| case "gz+base64", "gzip+base64", "gz+b64", "gzip+b64": |
Contributor
There was a problem hiding this comment.
any reason to have all of these alternate encoding names that are not described in the docs?
Contributor
Author
There was a problem hiding this comment.
We have to support the same options as cloudinit: https://github.com/coreos/coreos-cloudinit/blob/9a715eff2e45c94dfdc947c13760260e691a1708/config/decode.go#L34. I'm not going to document the alternate names, because I don't want to support them long term.
Contributor
|
lgtm |
crawford
added a commit
that referenced
this pull request
Mar 17, 2016
providers/vmware: add support for config encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to properly decode cloud-configs, which this needs to recognize
and ignore. While we are at it, we might as well add encoding support for
Ignition configs as well.
Fixes coreos/bugs#1170