Skip to content

platforms.adoc: add VirtualBox documentation#377

Merged
prestist merged 3 commits intocoreos:mainfrom
prestist:platforms-add-virtualbox
Apr 13, 2022
Merged

platforms.adoc: add VirtualBox documentation#377
prestist merged 3 commits intocoreos:mainfrom
prestist:platforms-add-virtualbox

Conversation

@prestist
Copy link
Copy Markdown
Contributor

Added documentation around virtualbox. Going through steps to add virtualbox to a supported type for our offical release as per coreos/fedora-coreos-tracker#1008

@prestist prestist changed the title Platforms.adoc: Added Virtualbox Platforms.adoc: Added VirtualBox. Mar 24, 2022
@prestist prestist force-pushed the platforms-add-virtualbox branch from 63d9b60 to 036ec77 Compare March 24, 2022 20:05
@prestist prestist changed the title Platforms.adoc: Added VirtualBox. platforms.adoc: Added VirtualBox. Mar 24, 2022
@prestist prestist force-pushed the platforms-add-virtualbox branch 5 times, most recently from 5345123 to 92bf5c4 Compare March 30, 2022 19:26
Copy link
Copy Markdown
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

@prestist prestist force-pushed the platforms-add-virtualbox branch from 92bf5c4 to 9190757 Compare April 1, 2022 17:56
@bgilbert bgilbert changed the title platforms.adoc: Added VirtualBox. platforms.adoc: add VirtualBox documentation Apr 1, 2022
@prestist prestist force-pushed the platforms-add-virtualbox branch 2 times, most recently from 0bfd176 to 2951188 Compare April 5, 2022 22:10
@bgilbert
Copy link
Copy Markdown
Contributor

bgilbert commented Apr 8, 2022

Requires coreos/coreos-assembler#2489 to land in a stable release.

Copy link
Copy Markdown
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally. I paired with @prestist on this, though, so shouldn't approve it.

Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Though the most valuable thing to do would be to have someone grab one of these new artifacts and run a test. IIUC @ravanelli has a mac with VBOX set up so maybe she would be willing.

@prestist prestist force-pushed the platforms-add-virtualbox branch from 25b56e4 to 279a38a Compare April 13, 2022 16:27
@prestist prestist marked this pull request as ready for review April 13, 2022 18:11
@prestist prestist merged commit cb9a03b into coreos:main Apr 13, 2022
@bgilbert
Copy link
Copy Markdown
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants