platforms.adoc: add VirtualBox documentation#377
Merged
prestist merged 3 commits intocoreos:mainfrom Apr 13, 2022
Merged
Conversation
63d9b60 to
036ec77
Compare
5345123 to
92bf5c4
Compare
92bf5c4 to
9190757
Compare
0bfd176 to
2951188
Compare
Contributor
|
Requires coreos/coreos-assembler#2489 to land in a stable release. |
dustymabe
reviewed
Apr 8, 2022
Member
dustymabe
left a comment
There was a problem hiding this comment.
A few suggestions. Though the most valuable thing to do would be to have someone grab one of these new artifacts and run a test. IIUC @ravanelli has a mac with VBOX set up so maybe she would be willing.
dustymabe
approved these changes
Apr 8, 2022
78c4165 to
25b56e4
Compare
25b56e4 to
279a38a
Compare
dustymabe
reviewed
Apr 13, 2022
eac79ac to
3fa8898
Compare
dustymabe
approved these changes
Apr 13, 2022
Contributor
|
LGTM! |
28 tasks
29 tasks
26 tasks
44 tasks
44 tasks
45 tasks
44 tasks
45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation around virtualbox. Going through steps to add virtualbox to a supported type for our offical release as per coreos/fedora-coreos-tracker#1008