Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Ready for review

trivial LGTM

cc @bgilbert for review.

This can probably be squashed down to one commit.

Looked through the resulting VM settings. We should enable EFI and maybe nested virtualization. Networking still seems to be NAT. Also, the storage controller is LSI Logic, which is an old favorite for virtualization but is a bit obscure. AHCI (Serial ATA) is supported, so maybe we should switch to that?

Networking still seems to be NAT

@bgilbert Are the settings possibly being lost during import? There is a section called "MAC Address Policy" that seems to imply that its overriding with NAT settings.

Yeah, it's possible. If we can't find a way around that, we should document the fact and how to switch to bridging.

@bgilbert This might be ready now. Go ahead and take a look!

I think it's okay to fix the remaining issues as a followup if it helps for FCOS freeze. For that purpose, tagging @dustymabe for review, since I can't approve my own PR.

@dustymabe Hey sorry, just pushed a quick fix around the ACHI port count. Could I get your re-approval?

Tested and LGTM!

/retest-required

/retest

The rhcos job is timing out fetching repo metadata for rhel-8-server-ose. That job previously passed on this PR, and the only subsequent changes have been to the OVF XML, which the job doesn't test.

/override ci/prow/rhcos

@bgilbert: Overrode contexts on behalf of bgilbert: ci/prow/rhcos