Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

sys-kernel/bootengine: bump to fix AWS/GCE disks#3456

Merged
dm0- merged 1 commit intocoreos:masterfrom
r7vme:bump-bootengine
Oct 30, 2018
Merged

sys-kernel/bootengine: bump to fix AWS/GCE disks#3456
dm0- merged 1 commit intocoreos:masterfrom
r7vme:bump-bootengine

Conversation

@r7vme
Copy link
Copy Markdown
Contributor

@r7vme r7vme commented Oct 26, 2018 •
edited
Loading

This change includes bootengine with fix for
AWS/GCE disks in ignition.

coreos/bootengine#149

Related bug: coreos/bugs#2481

@lucab
Copy link
Copy Markdown
Contributor

lucab commented Oct 26, 2018

@dm0- do we need to introduce any dependency here between bootengine and nmve-cli ebuilds?

@dm0-
Copy link
Copy Markdown
Contributor

dm0- commented Oct 26, 2018

Yeah, I guess that would be a good idea. Right now nvme-cli is only brought it by the overall coreos metapackage, so in theory, the kernel ebuild could try to generate an initramfs before it's installed. (In practice, the kernel is usually one of the last packages to build because the modules package takes so long.) So, specifically I think the dependency could be added on the two sys-kernel/coreos-kernel ebuilds.

@r7vme
Copy link
Copy Markdown
Contributor Author

r7vme commented Oct 30, 2018 •
edited
Loading

Ignore. Seems both sys-kernel/coreos-kernel already have bootengine dependencies

coreos-overlay/sys-kernel/coreos-kernel/coreos-kernel-4.14.78.ebuild

Line 30 in 7e5f5b4

>=sys-kernel/bootengine-0.0.4:=

coreos-overlay/sys-kernel/coreos-kernel/coreos-kernel-4.19.0-r1.ebuild

Line 30 in 7e5f5b4

>=sys-kernel/bootengine-0.0.4:=

Is it what we were looking for?

sys-kernel/bootengine: bump to fix AWS/GCE disks
75509cd 
This change includes bootengine with fix for
AWS/GCE disks in ignition. It also adds sys-apps/nvme-cli
dependency to sys-kernel/coreos-kernel.

coreos/bootengine#149
@r7vme
Copy link
Copy Markdown
Contributor Author

r7vme commented Oct 30, 2018

PTAL

Added sys-apps/nvme-cli as dependency to both sys-kernel/coreos-kernel ebuilds.

@lucab
Copy link
Copy Markdown
Contributor

lucab commented Oct 30, 2018 •
edited
Loading

No further comments from my side, @dm0- feel free to merge whenever suitable. Thanks a lot @r7vme for pushing this forward!

@dm0- dm0- merged commit e1b0b16 into coreos:master Oct 30, 2018
@r7vme r7vme deleted the bump-bootengine branch October 31, 2018 09:07
@seh seh mentioned this pull request Dec 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dm0- dm0- dm0- approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r7vme @lucab @dm0-