Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

Add udev rules for cloud storage disks#149

Merged
lucab merged 1 commit intocoreos:masterfrom
r7vme:aws_disks_udev
Oct 26, 2018
Merged

Add udev rules for cloud storage disks#149
lucab merged 1 commit intocoreos:masterfrom
r7vme:aws_disks_udev

Conversation

@r7vme
Copy link
Copy Markdown
Contributor

@r7vme r7vme commented Sep 26, 2018

Fixes: coreos/bugs#2481

This change allows to use proper AWS / GCE disk paths in ignition.

@r7vme r7vme mentioned this pull request Sep 26, 2018
Closed
lucab
lucab reviewed Sep 26, 2018
View reviewed changes
dracut/30ignition/module-setup.sh Outdated
mkswap

inst_script "$udevdir/cloud_aws_ebs_nvme_id" \
"/usr/sbin/cloud_aws_ebs_nvme_id"
Copy link
Copy Markdown
Contributor

@lucab lucab Sep 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not supposed to go under PATH though. udev can find its own helpers under /usr/lib/udev/.

Copy link
Copy Markdown
Contributor Author

@r7vme r7vme Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my uncertainty. Updated to /usr/lib/udev/

@lucab
Copy link
Copy Markdown
Contributor

lucab commented Sep 26, 2018

@r7vme thanks! Unfortunately I just double-checked and the script is using nvme which is currently not available inside the initramfs, so this PR won't work as is. It needs to install nvme first. Apart from that, all other commands used by the script are there though.

@r7vme
Copy link
Copy Markdown
Contributor Author

r7vme commented Sep 26, 2018

@lucab ah right, i've missed that point that we can miss nvme. I'll check on that.

@lucab lucab mentioned this pull request Oct 19, 2018
Open
Add udev rules for cloud disks and nvme binary
0dea279 
Fixes: coreos/bugs#2481

This change allows to use proper AWS / GCE disk paths in ignition.
@r7vme
Copy link
Copy Markdown
Contributor Author

r7vme commented Oct 24, 2018 •
edited
Loading

PTAL.

Added nvme binary that is used by AWS udev script. Also checked nvme-cli package and there are no other dependencies.

Nothing specific in shared objects deps for nvme.

$ ldd /usr/sbin/nvme  
        linux-vdso.so.1 (0x00007fff0afc8000)
        libc.so.6 => /lib64/libc.so.6 (0x00007fd5aa5d2000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fd5aa995000)

Size is quite small too

$ ls -sh /usr/sbin/nvme 
192K /usr/sbin/nvme

dm0-
dm0- approved these changes Oct 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dm0- dm0- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucab
lucab approved these changes Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucab lucab merged commit 107ce54 into coreos:master Oct 26, 2018
@r7vme r7vme deleted the aws_disks_udev branch October 26, 2018 12:54
@r7vme r7vme mentioned this pull request Oct 26, 2018
Merged
@seh seh mentioned this pull request Dec 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lucab lucab lucab approved these changes

@dm0- dm0- dm0- approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r7vme @lucab @dm0-