This repository was archived by the owner on Sep 18, 2020. It is now read-only.
35torcx: remove unused dependency on sysroot-boot#147
Merged
lucab merged 1 commit intocoreos:masterfrom Aug 13, 2018
Merged
Conversation
This removes the dependency on `sysroot-boot` from `torcx-profile-populate`, as the linked EFI-SYSTEM device is not available on diskless PXE nodes. The dependency itself is a leftover from a previous `ConditionPathExists` for `first_boot` gating, which instead is now handled by `torcx-profile-populate-generator`. Thus it should be safe to simply drop. Ref: coreos/bugs#2491
dm0-
approved these changes
Aug 13, 2018
lucab
added a commit
to lucab/coreos-overlay
that referenced
this pull request
Aug 13, 2018
This updates bootengine to include the fix for a torcx-related persistent boot failure on diskless PXE: coreos/bootengine#147 Fixes: coreos/bugs#2491
lucab
added a commit
to lucab/coreos-overlay
that referenced
this pull request
Aug 13, 2018
This updates bootengine to include the fix for a torcx-related persistent boot failure on diskless PXE: coreos/bootengine#147 Fixes: coreos/bugs#2491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on
sysroot-bootfromtorcx-profile-populate, as the linked EFI-SYSTEM device is notavailable on diskless PXE nodes.
The dependency itself is a leftover from a previous
ConditionPathExistsfor
first_bootgating, which instead is now handled bytorcx-profile-populate-generator.Thus it should be safe to simply drop.
Ref: coreos/bugs#2491