fix(tls): use temp dir for keylog test path#8010
Merged
Merged
Conversation
Collaborator
Author
|
I'll rebase + mark ready for review once #8009 lands in master. CI fails until it's merged. |
The keylog test case in TestTLS used a relative path, causing a tls.log file to be left in the source tree after each test run. Use t.TempDir() so the file is automatically cleaned up. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
32b2ec5 to
24c93fc
Compare
yongtang
approved these changes
Apr 4, 2026
Filippo125
pushed a commit
to Filippo125/coredns
that referenced
this pull request
Apr 10, 2026
Signed-off-by: Filippo <filippo.ferrazini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
The keylog test case in
TestTLSused a relative path, causing atls.logfile to be left in the source tree after each test run. Uset.TempDir()so the file is automatically cleaned up.2. Which issues (if any) are related?
Missed from #7537
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No.