plugin/forward: fix parsing error when handling TLS+IPv6 address#7848
Merged
Conversation
3878af5 to
bb66f9e
Compare
Member
|
@yangsenzk Would you mind to fix the DCO issue: https://github.com/coredns/coredns/pull/7848/checks?check_run_id=63369998286 You can use |
bb66f9e to
ce56a7c
Compare
Member
|
@yangsenzk I see the PR is still in draft mode. Is it trashy to be reviewed now? |
Contributor
Author
|
@yongtang sry, i'm on vacation. i will make more tests. |
ce56a7c to
80b1451
Compare
Contributor
Author
|
@yongtang I have made some unit tests and real test, it can work properly now. |
Signed-off-by: yangsenzk <yangsen.zk@qq.com>
80b1451 to
6b04f91
Compare
yongtang
approved these changes
Feb 25, 2026
yongtang
pushed a commit
to yongtang/coredns
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
fix plugin/forward bug: when handling TLS+IPv6 config like
forward . tls://::1%example.net ..., the ipv6 host will not be correctly parsed, but got weird[::1:853. The cause is there is a functionsplitZonenot support ipv6 format.2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
no
4. Does this introduce a backward incompatible change or deprecation?
no