fix: return SOA and NS records when queried for a record CNAMEd to origin#7808
Merged
Conversation
…igin Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com>
Contributor
Author
|
I have tested this locally. Using the following zone file (b.a.txt): and this Corefile: Here are the results:-
|
Contributor
Author
|
@yongtang Can you please look into this? |
Member
|
@shiv-tyagi Would you mind to write a test for it? |
Contributor
Author
|
Sure @yongtang. I have added a test. Please check. Thanks for looking at this. |
…lugin Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com>
Contributor
Author
|
@yongtang Is there anything else blocking this PR? PTAL and let me know, I will be happy to do additional changes whatever required. |
yongtang
approved these changes
Jan 22, 2026
yongtang
pushed a commit
to yongtang/coredns
that referenced
this pull request
Mar 18, 2026
…igin (coredns#7808) * fix: return SOA and NS records when queried for a record CNAMEd to origin Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com> * chore(test): add test for covering cname to origin scenario in file plugin Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com> --------- Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This fixes the file plugin to return answer to an NS/SOA query for a record which is CNAMEd to zone origin. This brings it inline with standard bind9 behaviour.
The problem was that we were ignoring SOA and NS records while looking up for the CNAME target (since those records are not stored in the zone tree). A simple fix is to propagate the query to upstream with target name and query type, which would return the answer correctly (as the upstream search still begins with current plugin and returns answer to NS/SOA records).
2. Which issues (if any) are related?
Fixes #6630
3. Which documentation changes (if any) need to be made?
NA
4. Does this introduce a backward incompatible change or deprecation?
NA