Add metadata for response Type and Class to Log.#7806
Merged
yongtang merged 1 commit intoJan 26, 2026
Merged
Conversation
Signed-off-by: Kelly Kane <kelly@hawknetworks.com>
yongtang
approved these changes
Jan 22, 2026
yongtang
pushed a commit
to yongtang/coredns
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Adds metadata for response Class and Type to the log plugin. This allows differentiation of "NODATA" from other NOERROR log lines when logging success and denial.
Adding
{/log/class} {/log/type}to the default format yields uniquely parsable data for each of these three test cases:2. Which issues (if any) are related?
n/a
3. Which documentation changes (if any) need to be made?
Added a quick snippet in README.md.
4. Does this introduce a backward incompatible change or deprecation?
No.
I wasn't sure where this code should live and so I put it somewhere where it worked. I'm not familiar at all with this codebase. If it should go somewhere else please let me know.