feat: structured ComponentConfig deserialization via cu29-value#762
Merged
Conversation
Collaborator
|
That is cool! |
gbin
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a typed
get_valuehelper onComponentConfigthat convertsRONvalues intocu29_value::Valueand deserializes into user-defined structs, with clearer error context and tests covering structured configs.Related Issue: #720
Change
ComponentConfig::get_value<T>to deserialize nested config entries into typed structs usingcu29_value.ron_value_to_cu_valueconverter (including map/seq/option handling andno_stdBTreeMapsupport).ConfigError::with_keyto include the failing config key in error messages.Impact (how can be used for RON configuration)
You can now encode richer, nested RON configuration and deserialize it directly into typed
Rust structs instead of manually parsing scalars.
Example RON (task config):
Example usage:
This enables strongly typed, nested configs in
RONwhile keeping the existing scalarget::<T>path unchanged.