Fix change after section flush coredump#29
Merged
Conversation
I removed the drop that is causing a unnecessary race condition and consider the flush_section as a proper close_section.
gbin
added a commit
that referenced
this pull request
Oct 23, 2024
* Workaround for the flush before write on section header. * Fix a coredump when a section is dropped after a section flush. I removed the drop that is causing a unnecessary race condition and consider the flush_section as a proper close_section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an unnecessary race condition on the drop of a SectionHandler and the actual update of the section header.
As we explicitly flush them anyway and semantically they are equivalent as closing them, I just moved the header update to the spot right before flushing them.