unified_logger: Refactoring to have a slab reader side too#27
Merged
Conversation
gbin
added a commit
that referenced
this pull request
Oct 23, 2024
* unified_logger: Refactoring to have a slab reader side too * WIP: end 2 end not passing yet. * export with slabs + tons of slab bugs. * temp disable on mac to see why the flushing fails. * Adding continue on error for CI. * reactivate the mac issue. * Avoid a corner case with large pages. * make flushing mac compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like we did on the writer side, we need to adapt the reading side to accommodate for "slab" files.
And a gazillion bug got discovered and squashed doing the end to end testing.