runtime loops: Part 1: added a notion of loop for the runtime plan#21
Merged
Conversation
mik90
reviewed
Aug 17, 2024
| Some(parse_str::<Type>(step.output_msg_type.clone().unwrap().as_str()).unwrap()) | ||
| } | ||
| } | ||
| CuExecutionUnit::Loop(_) => todo!("Needs to be implemented"), |
Collaborator
There was a problem hiding this comment.
Is it going to go through all of the steps in the loop and aggregate all of the message types?
And do we care about duplicates in this return type? Should it be changed into a set or is the type vec being indexed into or something?
Collaborator
Author
There was a problem hiding this comment.
I believe it works as is ... we will need an array of the type instead of just a type for each step of the loop as output. And at runtime we need to generate the index for the loop.
in the vector it will be:
[mainloop_type1 loop1_type1[] loop1type2[] mainloop_type2 ...]
we might want to go through some design lol
gbin
added a commit
that referenced
this pull request
Aug 19, 2024
* runtime loops: Part 1: added a notion of loop for the runtime plan * PR comments
gbin
added a commit
that referenced
this pull request
Oct 23, 2024
* runtime loops: Part 1: added a notion of loop for the runtime plan * PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on the back of adding batches, this adds the notion of loops in the runtime plan.