added six module for py3 compatibility; migrated all code#15
added six module for py3 compatibility; migrated all code#15cooncesean merged 3 commits intocooncesean:masterfrom
Conversation
six compatibility, tested with 2.7.6 and 3.4.3.
|
Hey @robin900 - thx for taking the time to get this project up to speed and compatible with Python 3. I have some light feedback and if you don't mind addressing, I'll get this merged asap.
Thx again for the work and the PR -- I appreciate your help :) |
|
@thesmallestduck @frifri -- would you mind reviewing these changes when you get a minute? |
|
@robin900 Thanks for that PR. |
|
I'll push a commit with the changes you requested. Would you want to create a live Mixpanel account, with whatever email address you prefer as the login, and seed some events in it, so that we can have a test suite that hits a live Mixpanel account? I have a tox.ini and a unittest-based test suite ready to go if you are willing to make an MXP account, put some events in, and add the _secret and _key to the test file. I'll make a separate PR for those. |
|
commit pushed. should be ready to merge. if you could make a PyPI release soon I can remove my git+ssh urls for mixpanel-query-py from all my projects :) BTW, my next PR will have a tox.ini and a test suite (very basic). But the test suite will fail because it doesn't have a valid key/secret for a Mixpanel account for testing. |
|
Huge - thx @robin900; we'll merge today and release to PyPi; I'll update this thread once that has been done. As for tests, do you think we could get away with using |
|
Haven't tested locally, but reads good. Thanks for doing this @robin900 |
added six module for py3 compatibility; migrated all code
|
@robin900 Release |
Tested with 2.7.6 and 3.4.3. Haven't tested every method, but request generation and response json parsing works fine so I foresee no problems.