Close ZipFile with context manager in unzip#2147
Merged
jensens merged 3 commits intocookiecutter:mainfrom Nov 8, 2025
Merged
Conversation
jensens
approved these changes
Nov 8, 2025
armandmasseaugit
pushed a commit
to armandmasseaugit/cookiecutter
that referenced
this pull request
Nov 19, 2025
* Update zipfile.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jens W. Klein <jk@kleinundpartner.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cookiecutter.zipfile.unzip()helper opened archives viaZipFile(zip_path)without closing them, leaving the file handle locked until garbage-collection.On Windows this prevented cached .zip files from being deleted or overwritten and could exhaust file descriptors on all platforms.
This patch wraps the archive processing in:
so the handle is deterministically released even when extraction errors (e.g., wrong password) occur. No behavioural changes beyond eliminating the resource leak.