Merged
Conversation
kurtmckee
reviewed
Jul 24, 2023
Member
kurtmckee
left a comment
There was a problem hiding this comment.
I cannot tell whether this fixes the linked issues.
@vemonet Are there existing tests that you could point to that demonstrate the linked issues are fixed? If not, would you add tests to demonstrate the root problem is resolved?
Member
|
@vemonet Could you please provide tests to confirm both issues are really fixed? |
…is properly passed to generate the repo
Contributor
Author
|
Hi @ericof and @kurtmckee I added a test that generates a project with a replay file, and check if the replayed values are properly used in the generated file It fails if you remove the changes I made to fix the replat (because the replayed values are not passed to the context), and works with my change |
ericof
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error where the context defined in the replay file was not taken into account was introduced with #1758 (which added prompts for entries missing from the replay file). It seems to impact a few people: #1900 and #1902)
This PR:
Closes #1900
Closes #1902
@ericof @kurtmckee