Skip to content

Prompt with replay file#1758

Merged
ericof merged 14 commits intocookiecutter:mainfrom
w1ndblow:prompt_replay_file
Jul 11, 2023
Merged

Prompt with replay file#1758
ericof merged 14 commits intocookiecutter:mainfrom
w1ndblow:prompt_replay_file

Conversation

@w1ndblow
Copy link
Copy Markdown
Contributor

@w1ndblow w1ndblow commented Aug 4, 2022

if replayfile have not all answers relatively cookiecutter config file it'll execute prompt operation

@w1ndblow
Copy link
Copy Markdown
Contributor Author

hi, @audreyfeldroy, @browniebroke, @ericof, @hackebrot, @insspb, @pydanny, @simobasso, @ssbarnea could you take a look my PR, please

Copy link
Copy Markdown
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w1ndblow Thanks for your work on this.

Would you add tests that demonstrate that this feature is working as expected?

freezegun
safety
pre-commit
defer
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missclick

@ericof ericof added the enhancement This issue/PR relates to a feature request. label Jun 13, 2023
@w1ndblow
Copy link
Copy Markdown
Contributor Author

i added one test, i can add more if needed

@w1ndblow w1ndblow requested a review from kurtmckee June 21, 2023 08:46
@w1ndblow
Copy link
Copy Markdown
Contributor Author

w1ndblow commented Jul 7, 2023

hi, could any one merge it? i merged this with main 3 times already :)

@ericof ericof added this to the 3.0.0 milestone Jul 7, 2023
@ericof ericof self-requested a review July 7, 2023 20:34
@ericof ericof modified the milestones: 3.0.0, 2.2.3 Jul 11, 2023
@ericof ericof merged commit 25f2e58 into cookiecutter:main Jul 11, 2023
@vemonet vemonet mentioned this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This issue/PR relates to a feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants