Skip to content

fixes prompting private rendered dicts#1504

Merged
ssbarnea merged 16 commits intocookiecutter:masterfrom
juhuebner:master
May 12, 2021
Merged

fixes prompting private rendered dicts#1504
ssbarnea merged 16 commits intocookiecutter:masterfrom
juhuebner:master

Conversation

@juhuebner
Copy link
Copy Markdown
Contributor

fixes #1502

juhuebner and others added 14 commits February 8, 2021 21:26
commit f0ac6a0
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:33:43 2021 +0100

    5th

commit 2af3902
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:20:18 2021 +0100

    4th try

commit 903f674
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:07:46 2021 +0100

    3rd try to get artifacts

commit c8a5178
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:46:45 2021 +0100

    get artifact 2nd try

commit 287c8eb
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:32:58 2021 +0100

    get coverage artifact

commit 6b11f6a
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:18:24 2021 +0100

    changed codecov action
commit 661c50b156b5db856f845391104d08340f4d6be1
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Tue Feb 9 19:00:27 2021 +0100

    modified coverage for code which is unreachable s.a. https://bugs.python.org/issue39340

commit f9cb8e7a1df21d029e2da17a9742f89d9bea0170
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Tue Feb 9 10:00:16 2021 +0100

    added posargs to tox.ini
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label May 12, 2021
@ssbarnea ssbarnea merged commit 95ebdcb into cookiecutter:master May 12, 2021
@simobasso
Copy link
Copy Markdown
Member

Thanks @juhuebner 🌮!

@simobasso simobasso mentioned this pull request May 15, 2021
cagonza6 pushed a commit to cagonza6/cookiecutter that referenced this pull request Jun 16, 2021
* fixes private dir handling

* added patch branch to CI coverage.yml

* changed codecov action

* get coverage artifact

* get artifact 2nd try

* 3rd try to get artifacts

* 4th try

* 5th

* Squashed commit of the following:

commit f0ac6a0
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:33:43 2021 +0100

    5th

commit 2af3902
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:20:18 2021 +0100

    4th try

commit 903f674
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 23:07:46 2021 +0100

    3rd try to get artifacts

commit c8a5178
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:46:45 2021 +0100

    get artifact 2nd try

commit 287c8eb
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:32:58 2021 +0100

    get coverage artifact

commit 6b11f6a
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Mon Feb 8 22:18:24 2021 +0100

    changed codecov action

* Squashed commit of the following:

commit 661c50b156b5db856f845391104d08340f4d6be1
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Tue Feb 9 19:00:27 2021 +0100

    modified coverage for code which is unreachable s.a. https://bugs.python.org/issue39340

commit f9cb8e7a1df21d029e2da17a9742f89d9bea0170
Author: Jens Hübner <jhuebner@nano.uni-hannover.de>
Date:   Tue Feb 9 10:00:16 2021 +0100

    added posargs to tox.ini

* applied black

* cleanup

* removed dev leftovers

* clean-up docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

private rendered dict is still prompted

4 participants