docs: rewrite the conditional files / directories example description.#1437
Merged
insspb merged 3 commits intocookiecutter:masterfrom Dec 26, 2020
Merged
Conversation
ssbarnea
previously requested changes
Aug 14, 2020
Member
ssbarnea
left a comment
There was a problem hiding this comment.
That construct after comma does not sound right to me. There are some improvements in proposed change but is not ready yet.
Contributor
Author
|
I just mirrored the syntax of the previous approved example Check out the rephrased version: 530367b |
The example didn't match the description structure of the previous example and it mentioned the pre_gen_project, when it should be post_gen_project hook.
530367b to
7bf4d68
Compare
Contributor
Author
|
Hi @ssbarnea, can I do anything to speed up the merging process of this contribution? Thanks! |
insspb
approved these changes
Dec 26, 2020
insspb
approved these changes
Dec 26, 2020
Closed
cagonza6
pushed a commit
to cagonza6/cookiecutter
that referenced
this pull request
Jun 16, 2021
cookiecutter#1437) * docs: rewrite the conditional files / directories example description. The example didn't match the description structure of the previous example and it mentioned the pre_gen_project, when it should be post_gen_project hook. * docs: improve hooks example phrasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example didn't match the description structure of the previous
example and it mentioned the pre_gen_project, when it should be
post_gen_project hook.