Use sys.executable when invoking python interpreter from tests#1221
Merged
luzfcb merged 1 commit intocookiecutter:masterfrom Sep 2, 2019
Merged
Use sys.executable when invoking python interpreter from tests#1221luzfcb merged 1 commit intocookiecutter:masterfrom
luzfcb merged 1 commit intocookiecutter:masterfrom
Conversation
When we only have python3 installed, the test for missing argument is failing because there is no "python" executable. Use `sys.executable` instead. Also set environment correctly, like done in 7024d3b.
insspb
approved these changes
Sep 2, 2019
Member
|
LGTM |
ssbarnea
approved these changes
Sep 2, 2019
luzfcb
approved these changes
Sep 2, 2019
Contributor
luzfcb
left a comment
There was a problem hiding this comment.
LGTM. @vincentbernat Thanks.
hackebrot
added a commit
that referenced
this pull request
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we only have python3 installed, the test for missing argument is
failing because there is no "python" executable. Use
sys.executableinstead. Also set environment correctly, like done in 7024d3b.