Skip to content

Update file mode for hooks.py to be not executable#1217

Merged
hackebrot merged 1 commit intocookiecutter:masterfrom
hackebrot:change-file-mode-for-hooks-module
Aug 28, 2019
Merged

Update file mode for hooks.py to be not executable#1217
hackebrot merged 1 commit intocookiecutter:masterfrom
hackebrot:change-file-mode-for-hooks-module

Conversation

@hackebrot
Copy link
Copy Markdown
Member

Our linter failed because hooks.py does not have a shebang. But I don't think it's supposed to be executable. Please let me know your thoughts! 🙇

https://travis-ci.com/cookiecutter/cookiecutter/jobs/228509876

See also #1195

@hackebrot hackebrot added the bug This issue/PR relates to a bug. label Aug 27, 2019
Copy link
Copy Markdown
Member

@insspb insspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It never was executable. This flag was added with last PR #1147, but not required.

@hackebrot
Copy link
Copy Markdown
Member Author

Thanks for the review @insspb! 🍪

@hackebrot hackebrot merged commit f9c7873 into cookiecutter:master Aug 28, 2019
@hackebrot hackebrot deleted the change-file-mode-for-hooks-module branch August 28, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug. high-priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants