Skip to content

Require pip 9.0.0 or newer for tox environments#1215

Merged
hackebrot merged 2 commits intocookiecutter:masterfrom
hackebrot:fix-build-failure-for-py2
Aug 27, 2019
Merged

Require pip 9.0.0 or newer for tox environments#1215
hackebrot merged 2 commits intocookiecutter:masterfrom
hackebrot:fix-build-failure-for-py2

Conversation

@hackebrot
Copy link
Copy Markdown
Member

@insspb
Copy link
Copy Markdown
Member

insspb commented Aug 26, 2019

As more and more projects drop support of python 2.7 we will face such issues more frequently.
If I understand correctly this PR does not fix it in appveyor.
I think we should make some sprint in September to close as many current issues as possible, release 1.7.0 and drop python 2.7 support after it.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1215   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         784     784           
======================================
  Hits          784     784

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dade3bd...5e65edf. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1215   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         784     784           
======================================
  Hits          784     784

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dade3bd...5e65edf. Read the comment docs.

Copy link
Copy Markdown
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 9.0.0 is decently old enough to be required.

@hackebrot hackebrot merged commit ce17e3a into cookiecutter:master Aug 27, 2019
@hackebrot hackebrot deleted the fix-build-failure-for-py2 branch August 27, 2019 09:53
@hackebrot
Copy link
Copy Markdown
Member Author

Thanks for the review @ssbarnea! 🍪

@ssbarnea
Copy link
Copy Markdown
Member

@insspb Lets not diverge, I hope we do not discuss dropping py27 before 2020. I use cookiecutter in molecule and I am sure I will not drop it until it ends EOL. Even after I am likely to keep it until I am forced to drop it. I am more likely to replace a library that drops support for it than dropping support for py27.

hackebrot added a commit that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants