README.md: avoid []byte -> string allocation/copy#98
Merged
coocood merged 1 commit intocoocood:masterfrom Mar 27, 2021
extemporalgenome:patch-1
Merged
README.md: avoid []byte -> string allocation/copy#98coocood merged 1 commit intocoocood:masterfrom extemporalgenome:patch-1
coocood merged 1 commit intocoocood:masterfrom
extemporalgenome:patch-1
Conversation
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a `fmt.Println` call. With this change, it uses `fmt.Printf("%s\n", ...)`, which should be used in any case involving `Println` and a `[]byte` that's intended to be interpreted as string data.
Owner
|
Good suggestion, Thank you! |
SilverHL
pushed a commit
to SilverHL/freecache
that referenced
this pull request
Sep 27, 2021
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a `fmt.Println` call. With this change, it uses `fmt.Printf("%s\n", ...)`, which should be used in any case involving `Println` and a `[]byte` that's intended to be interpreted as string data.
Change-Id: I01e6067e3c2da12dfd75e391728265b749b848ca
SilverHL
pushed a commit
to SilverHL/freecache
that referenced
this pull request
Sep 27, 2021
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a `fmt.Println` call. With this change, it uses `fmt.Printf("%s\n", ...)`, which should be used in any case involving `Println` and a `[]byte` that's intended to be interpreted as string data.
Change-Id: I01e6067e3c2da12dfd75e391728265b749b848ca
SilverHL
pushed a commit
to SilverHL/freecache
that referenced
this pull request
Sep 27, 2021
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a `fmt.Println` call. With this change, it uses `fmt.Printf("%s\n", ...)`, which should be used in any case involving `Println` and a `[]byte` that's intended to be interpreted as string data.
Change-Id: I01e6067e3c2da12dfd75e391728265b749b848ca
SilverHL
pushed a commit
to SilverHL/freecache
that referenced
this pull request
Sep 27, 2021
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a `fmt.Println` call. With this change, it uses `fmt.Printf("%s\n", ...)`, which should be used in any case involving `Println` and a `[]byte` that's intended to be interpreted as string data.
Change-Id: I01e6067e3c2da12dfd75e391728265b749b848ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeCache invests a lot of effort to minimize GC overhead, yet the README example has a case where a (potentially very large) copy is made just as part of a
fmt.Printlncall. With this change, it usesfmt.Printf("%s\n", ...), which should be used in any case involvingPrintlnand a[]bytethat's intended to be interpreted as string data.