Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Dec 24, 2025

Fixes #9286

Summary by cubic

Refactors agent metadata updates to include completion state and whether the session made changes. Splits diff, summary, and usage collection into helpers and keeps backward compatibility with the old signature.

  • Refactors
    • updateAgentMetadata now accepts options { history, isComplete } while still supporting a history array.
    • Diff stats, conversation summary, and session usage are collected via small helpers; metadata is posted only when present.
    • When isComplete is true, metadata includes isComplete and hasChanges (derived from git diff).
    • serve.ts passes { history, isComplete: true } on shutdown to mark session completion.

Written for commit ca70241. Summary will update automatically on new commits.

@sestinj sestinj requested a review from a team as a code owner December 24, 2025 02:39
@sestinj sestinj requested review from RomneyDa and removed request for a team December 24, 2025 02:39
@continue
Copy link
Contributor

continue bot commented Dec 24, 2025

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

1 similar comment
@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 24, 2025
@github-actions
Copy link

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions
Copy link

github-actions bot commented Dec 24, 2025

✅ Review Complete

Code Review Summary

⚠️ AI review failed. Please check the Continue API key and configuration.

Troubleshooting

  • Verify the CONTINUE_API_KEY secret is set correctly
  • Check that the organization and config path are valid
  • Ensure the Continue service is accessible

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@continue
Copy link
Contributor

continue bot commented Dec 24, 2025

Documentation Review

I've reviewed this PR for documentation impacts. No documentation updates are needed because:

  • This is an internal refactoring that improves metadata tracking for agent sessions
  • The changes don't affect user-facing behavior or APIs
  • The completion state and change detection happen automatically behind the scenes
  • The existing Agents Overview monitoring section adequately describes what users see in Mission Control (summary, diff, logs) without needing to expose internal metadata implementation details

The isComplete and hasChanges flags are internal metadata that improve session tracking in the control plane, but users interact with the results through the Mission Control UI rather than needing to understand these fields directly.

@continue
Copy link
Contributor

continue bot commented Dec 24, 2025

CI Failure Analysis

The failing test on macos-latest, Node 18 is not related to this PR's changes:

Failed Test: TUIChat - User Input Tests > handles special characters in input without crashing [REMOTE MODE]

Error: Test expects special characters !@#$%^&*() to appear in the UI, but they're not being rendered.

Root Cause: This is a flaky/pre-existing test failure in the TUI chat component, completely unrelated to the metadata refactoring in extensions/cli/src/util/exit.ts and extensions/cli/src/commands/serve.ts.

Evidence:

  • All other Node versions pass (18, 20, 22, 24 on ubuntu/windows, and 20, 22, 24 on macOS)
  • Only macos-latest, Node 18 fails
  • The PR only touches metadata collection code, not UI rendering
  • This appears to be a timing/rendering issue in the test infrastructure

Recommendation: This is a flaky test that should be addressed separately. The PR changes are sound and all relevant tests pass.

continue-development-app bot pushed a commit that referenced this pull request Dec 24, 2025
Co-authored-by: peter-parker <e2e@continue.dev>
Co-Authored-By: Continue <noreply@continue.dev>
@sestinj sestinj merged commit ec777c1 into main Dec 24, 2025
57 of 60 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Dec 24, 2025
@sestinj sestinj deleted the nate/refactor-agent-metadata-completion-flag branch December 24, 2025 02:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Jan 13, 2026

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Jan 14, 2026

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve agent metadata tracking with completion state and changes detection

2 participants