feat: improve compaction UI, show compaction message as status message #7695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI Code ReviewAI review failed due to service initialization issues. Please check the Continue API key and configuration. No specific line comments generated. 💡 To request a new detailed review, comment |
a4ca79e to
e2f3c44
Compare
e2f3c44 to
d74fde6
Compare
d74fde6 to
f951269
Compare
Introduces ActionStatus component and refactor normal loading message into ActionStatus
f951269 to
54846d4
Compare
tingwai
commented
Sep 11, 2025
Contributor
Author
tingwai
left a comment
There was a problem hiding this comment.
Ready for review now
| ); | ||
| expect(mockCallbacks.onSystemMessage).toHaveBeenCalledWith( | ||
| "✓ Chat history auto-compacted successfully.", | ||
| "Chat history auto-compacted successfully.", |
Contributor
Author
There was a problem hiding this comment.
Removed checkmarks to be consistent with other system messages, we don't use check marks anywhere else
| @@ -1,3 +1,5 @@ | |||
| /* eslint-disable max-lines */ | |||
Contributor
Author
There was a problem hiding this comment.
I tried refactoring useChat.ts to reduce line numbers but it got way too messy, would be better to tackle that another time / PR
Contributor
|
Did something similar here: #7541 |
RomneyDa
approved these changes
Sep 11, 2025
Collaborator
RomneyDa
left a comment
There was a problem hiding this comment.
Looks good, nice tests
Collaborator
Contributor
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously compaction messages were not very clear and would disappear when its done compacting so I've
ActionStatuscomponent so that when it is compacting there's an animation so users won't think its stuck/compactslash command now also uses this new component/compactis calledFor video demo purposes I've set my compaction threshold extremely low so every new message causes a compaction.
Screen.Recording.2025-09-11.at.10.35.44.AM.mov