Skip to content

Conversation

@chezsmithy
Copy link
Contributor

@chezsmithy chezsmithy commented Sep 3, 2025

Description

Integrate Conversation Summary into the Chat History eliminating the current issues where the Conversation History overlaps the Mentions menu.

Create a more fluid integration of the conversation summary making it look like an assistant response.

When generating the summary, block the enter button to avoid having two requests active.

Move the generating summary message to the Lump Toolbar to unify it with Generating and Applying messages.

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

Added new UI tests.
Performed manual testing.


Summary by cubic

Integrates conversation summaries directly into the chat timeline as assistant-style messages, fixes UI overlap with the Mentions menu, and shows a unified “Generating Summary” state in the Lump toolbar. Input is disabled during compaction to prevent double submissions.

  • Bug Fixes

    • Prevented Mentions menu overlap by rendering summaries inline in chat.
    • Blocked Enter/submit while a summary is generating to avoid parallel requests.
  • Refactors

    • Removed ConversationSummary component; Chat now renders summaries with an assistant icon.
    • Moved the “Previous Conversation Compacted” indicator to Chat and show it only for the latest summary.
    • Added a Lump toolbar state for “Generating Summary” and disabled input/editor while compaction is active.
    • Introduced setConversationSummary in session slice; used compactionLoading to drive UI state.
    • Added UI tests for compaction flows and summary display.

@chezsmithy chezsmithy requested a review from a team as a code owner September 3, 2025 07:20
@chezsmithy chezsmithy requested review from sestinj and removed request for a team September 3, 2025 07:20
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 3, 2025
@chezsmithy
Copy link
Contributor Author

Potential fix for #7529 by refactoring the compaction summary into the timeline in a more consistent way.

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested, some things I noticed

  • Potentially duplicate conversation summary title (maybe a model thing)
    I would just remove hardcoded conversation summary title
image - no way to delete compaction, seems to delete entire message - personally I preferred the collapsible/expandable, but I do like that it shows with proper styled markdown now. Maybe we could merge the two a bit

</div>
</div>
)}
{/* Compaction indicator now handled in Chat.tsx */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like islatestsummary no longer used in the component? Could just remove the comments 👍

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 11, 2025
@sestinj sestinj removed their request for review September 22, 2025 20:03
@chezsmithy chezsmithy closed this Oct 14, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@github-actions github-actions bot deleted the fix-compaction-summary branch November 3, 2025 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants