Skip to content

feat: notch cleanup and settings improvements #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sestinj merged 39 commits into from
Sep 10, 2025
Merged

feat: notch cleanup and settings improvements #7667

sestinj merged 39 commits into from
Sep 10, 2025

Conversation

@Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Sep 9, 2025 •
edited by RomneyDa
Loading

@RomneyDa speaking: I'm changing the base of this to main since I messed up the git history on the original PR
See discussion on original PR here #7561

Summary by cubic

Stabilizes and reorganizes chat tool-call tests to reduce flakiness and improve isolation across edit and parallel tool call scenarios. Tests now configure the mock model via Redux, mock required IDE responses, and split large suites for clarity.

  • Bug Fixes

    • Clear localStorage/sessionStorage, reset ideMessenger, and dispatch setInactive in beforeEach to avoid cross-test leaks.
    • Mock context/getSymbolsForFiles and getWorkspaceDirs to prevent streaming errors.
    • Add small delays and waits to ensure cleanup and streaming complete before assertions.

  • Refactors

    • Replace addAndSelectMockLlm with updateConfig to select the mock chat model directly.
    • Move YOLO edit flow to EditToolScenariosYolo.test.tsx; simplify EditToolScenarios.test.tsx.
    • Split ParallelToolCalls into Basic, Actions, and Streaming test files; remove the old combined suite.

sestinj and others added 30 commits August 12, 2025 19:15
@sestinj
feat: improve settings UI
3dd8b92
@sestinj
move everything from notch to settings
1d9278f
@sestinj
more notch updates
b757bd5
@sestinj
remove folder and codebase from default context providers
18d0b42
@sestinj
make cmd+enter use active file, remove codebase shortcut
2ae4026
@sestinj
fix
b1eeab6
@sestinj
improve session title setting description
d0cb122
@sestinj
add model button in settings page
37b33fd
@sestinj
add model button in settings page
8eca6d3
@sestinj
tabs to left at breakpoint
099ed2b
@sestinj
fix: remove extraneous scroll
c967b3b
@sestinj
don't show "or Alt enter"
9b68dea
@Patrick-Erichsen
convert to sidebar
1de8b3d
@Patrick-Erichsen
sidebar polish
67be581
@Patrick-Erichsen @claude
Resolve merge conflicts from main
b5fe6b7 
- Resolved conflicts in core/config/default.ts: kept settings-improvements context providers while adding defaultConfig from main
- Resolved conflicts in gui/src/components/AssistantAndOrgListbox/index.tsx: kept ToolTip import from main
- Resolved conflicts in gui/src/components/mainInput/InputToolbar.tsx: kept settings-improvements useCodebase logic with main's ToolTip structure and getMetaKeyLabel
- Resolved conflicts in gui/src/components/mainInput/Lump/LumpToolbar/BlockSettingsTopToolbar.tsx: removed docs section and used plain string tooltips for tools and MCP sections

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Patrick-Erichsen
handle merge conflicts
e92a109
@Patrick-Erichsen
move back btn
94d3219
@Patrick-Erichsen
Resolve merge conflict in UserSettingsForm.tsx
d3f0699
@Patrick-Erichsen
progress
b0fbf2f
@Patrick-Erichsen
combine agent/org selection
c7b3019
@Patrick-Erichsen
done
1c720c9
@Patrick-Erichsen
address feedback
b9ed555
@Patrick-Erichsen
polish
d2418e8
@Patrick-Erichsen
Update BlockSettingsTopToolbar.tsx
a1d18e4
@Patrick-Erichsen
ty's feedback
3fa83b7
@Patrick-Erichsen
dallins feedback
b4dbb32
@Patrick-Erichsen
udpates
d6b7ed4
@Patrick-Erichsen
Update UserSettingsSection.tsx
c1b113f
@Patrick-Erichsen
prettier fixes
ef77787
@Patrick-Erichsen
Update MockIdeMessenger.ts
89a4c9b
@Patrick-Erichsen Patrick-Erichsen requested review from RomneyDa and removed request for a team September 9, 2025 20:58
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

⚠️ AI review completed but no review output was generated. Check the action logs for details.

💡 To request a new review, comment @continue-general-review

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 6 files

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@RomneyDa RomneyDa changed the base branch from settings-improvements to main September 10, 2025 00:31
@RomneyDa RomneyDa changed the title Settings improvements test fix Settings improvements Sep 10, 2025
@RomneyDa RomneyDa changed the title Settings improvements feat: notch cleanup and settings improvements Sep 10, 2025
RomneyDa
RomneyDa previously approved these changes Sep 10, 2025
View reviewed changes
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, already reviewed a few times on original PR (see description) this is the final stamp

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2025
@RomneyDa RomneyDa mentioned this pull request Sep 10, 2025
Closed
RomneyDa
RomneyDa previously approved these changes Sep 10, 2025
View reviewed changes
@sestinj sestinj merged commit faac029 into main Sep 10, 2025
41 of 42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 10, 2025
@sestinj sestinj deleted the settings-improvements-test-fix branch September 10, 2025 04:42
@github-actions github-actions bot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Sep 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 11, 2025

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@RomneyDa RomneyDa RomneyDa left review comments

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:XXL This PR changes 1000+ lines, ignoring generated files. tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Patrick-Erichsen @sestinj @RomneyDa