feat: notch cleanup and settings improvements #7561
Conversation
- Resolved conflicts in core/config/default.ts: kept settings-improvements context providers while adding defaultConfig from main - Resolved conflicts in gui/src/components/AssistantAndOrgListbox/index.tsx: kept ToolTip import from main - Resolved conflicts in gui/src/components/mainInput/InputToolbar.tsx: kept settings-improvements useCodebase logic with main's ToolTip structure and getMetaKeyLabel - Resolved conflicts in gui/src/components/mainInput/Lump/LumpToolbar/BlockSettingsTopToolbar.tsx: removed docs section and used plain string tooltips for tools and MCP sections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
RomneyDa
left a comment
There was a problem hiding this comment.
Generally agree with cubic feedback, the only blocker I saw is I think the useActiveFile boolean inversion would break it
There was a problem hiding this comment.
@Patrick-Erichsen submitting a second PR based on smoke testing
Rule names disappear on small screens
Prompts similarly unintelligible
Model settings icon needs a flex-shrink-0
Generally lots of padding on small screens where there maybe doesn't need to be, and lots of padding in general, e.g. between Tool policy groups:
Or after "Documentation":
Chevron on config page narrow version doesn't fit
Add some padding to the trigger for assistant/org menu so it doesn't look like this:
and this
Need to disable the refresh MCP button while it's refreshing, clicking twice causes this error:
Same with authenticate button for MCP
MCP Tools no longer show args with descriptions? I look at that sometimes
No line between autocomplete and edit model roles:
Maybe was already a bug but large rules scroll the close dialog x off the page when expanded
I think cubic had the same feedback but you should be able to select assistants with non-fatal errors, can't currently
Also consider sorting assistants to move the ones with fatal errors to the bottom, partly to make it more likely that the selected one will be visible when you open the menu
Justify-start so the settings and agent icons are at the top of the section. Centered looks off
Org padding between name/settings disappears
Feels a bit odd that "Organizations" is so much longer than other options
Consider "Orgs"
Going back from token usage page doesn't go back to the help page
Even on mid screens the disable autocomplete in files input is smashed
Consider adding a min width with 3 or 4 presets to the navbar so that it expands on wider screens
0c324ce to
b9ed555
Compare
RomneyDa
left a comment
There was a problem hiding this comment.
Last nitpicks
still think justify-start would look significantly better here with icons at the top of the row
Padding here is monstrous
Assistant menu looks bad on narrower, left truncated
Centering off on the plus
+1 to a wider navbar width on wider screens, is unescessarily narrow here
I think the chevron needs to be added back somehow to make it clear that this is clickable
add a div around error icon so that justify between works
|
Closing in favor of PR whose branch is off of this one |
Uh oh!
There was an error while loading. Please reload this page.