fix: Use Digitalsourcetype with Builder intents#1586
Merged
Conversation
CodSpeed Performance ReportMerging #1586 will not alter performanceComparing Summary
Footnotes
|
ok-nick
reviewed
Nov 10, 2025
…uth/c2pa-rs into mathern/digital-source-type
ok-nick
approved these changes
Nov 10, 2025
builder.actions.auto_created_actions, auto_opened_actions and auto_palaced actions. These are all now disabled and do not set digitalSourceType. they are still tested with individual unit tests. I set the default intent to edit in test_settings.toml. ca_test.json known goods are updated. If intent is set, it always takes precedent over auto_opened and auto_create.
ok-nick
approved these changes
Nov 12, 2025
dyro
approved these changes
Nov 12, 2025
Merged
gpeacock
added a commit
that referenced
this pull request
Dec 16, 2025
* fix: Take Digital source type into account * fix: Take Digital source type into account * fix: CLarify comment * fix: Remove debug logs * fix: FOrmat * fix: Fix the API * removes default and test file settings for builder.actions.auto_created_actions, auto_opened_actions and auto_palaced actions. These are all now disabled and do not set digitalSourceType. they are still tested with individual unit tests. I set the default intent to edit in test_settings.toml. ca_test.json known goods are updated. If intent is set, it always takes precedent over auto_opened and auto_create. * fix: Typos --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
ribhavh
pushed a commit
to ribhavh/c2pa-rs
that referenced
this pull request
Jan 8, 2026
* fix: Take Digital source type into account * fix: Take Digital source type into account * fix: CLarify comment * fix: Remove debug logs * fix: FOrmat * fix: Fix the API * removes default and test file settings for builder.actions.auto_created_actions, auto_opened_actions and auto_palaced actions. These are all now disabled and do not set digitalSourceType. they are still tested with individual unit tests. I set the default intent to edit in test_settings.toml. ca_test.json known goods are updated. If intent is set, it always takes precedent over auto_opened and auto_create. * fix: Typos --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Either I am using set_intent on the Builder wrong by just calling set_intent with Create and a DigitalSourceType (without changing default settings), or we need a small settings code update to pass through the picked digital source type.
Observed issue: When using the SDK OOTB (no changes in default settings), the set_intent API with Create intent ignores the Digital Source Type passed in (it falls back to the default value in settings).
@gpeacock @ok-nick If you have working examples of passing through digital source types with the set_intent APIs, please show me/tell me what is done wrong in the C API tests. Thanks!
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.