playbooks, test/system: Drop the PODMAN and SKOPEO environment variables#1592
Merged
debarshiray merged 3 commits intocontainers:mainfrom Nov 14, 2024
Conversation
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 12, 2024
1e9c1b6 to
95be6f7
Compare
The package providing /usr/share/pkgconfig/bash-completion.pc changed
from bash-completion to bash-completion-devel in Fedora 41 onwards [1].
This meant that the Bash completions were no longer being generated and
installed by the CI.
[1] Fedora bash-completion commit d1f5dc48c0440cc6
https://src.fedoraproject.org/rpms/bash-completion/c/d1f5dc48c0440cc6
https://bugzilla.redhat.com/show_bug.cgi?id=1457164
containers#1593
Unlike Fedora, where the package providing bash-completion.pc changed in
Fedora 41 onwards [1,2], it hasn't changed in CentOS Stream 9. So, this
doesn't change the behaviour of the CI.
However, the Fedora Packaging Guidelines recommend using pkgconfig(...)
to depend on a *.pc file [3], instead of the name of the package, and
there has been a problem on Fedora caused by not doing that. Therefore,
it's better to follow the guidelines for consistency and safety.
[1] Fedora bash-completion commit d1f5dc48c0440cc6
https://src.fedoraproject.org/rpms/bash-completion/c/d1f5dc48c0440cc6
https://bugzilla.redhat.com/show_bug.cgi?id=1457164
[2] Commit 2049199
containers@204919917e4af528
[3] https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
containers#1593
The toolbox(1) binary always relies on the PATH environment variable to find the podman(1) and skopeo(1) binaries. There's no way to override those with the PODMAN and SKOPEO environment variables, and they only affect any direct use of podman(1) and skopeo(1) within the test suite. Therefore, offering the PODMAN and SKOPEO environment variables in their current form is needlessly confusing and misleading, and can lead to surprises arising from different podman(1) and skopeo(1) binaries being used in different places. Either toolbox(1) should also honour them or the test suite shouldn't offer them. The former is more complicated without any obvious need for it, so the latter was chosen. containers#1592
95be6f7 to
fbffd45
Compare
Member
Author
|
recheck |
Member
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.