Skip to content

.zuul, test/system: Simplify line count checks by using Bats >= 1.10.0#1546

Merged
debarshiray merged 1 commit intocontainers:mainfrom
debarshiray:wip/rishi/test-system-cdi-line-count-checks-bats-1.10
Sep 19, 2024
Merged

.zuul, test/system: Simplify line count checks by using Bats >= 1.10.0#1546
debarshiray merged 1 commit intocontainers:mainfrom
debarshiray:wip/rishi/test-system-cdi-line-count-checks-bats-1.10

Conversation

@debarshiray
Copy link
Copy Markdown
Member

@debarshiray debarshiray commented Sep 18, 2024 •
edited
Loading

Commit 87eaeea already added a dependency on Bats >= 1.10.0,
which is present on Fedora >= 39. Therefore, it should be exploited
wherever possible to simplify things.

Currently, the CI has been frequently timing out on stable Fedora nodes.
So, increase the timeout from 1 hour 50 minutes to 2 hours to avoid
that.

For what it's worth, the timeout for Fedora Rawhide nodes is 2 hours 10
minutes and it seems enough.

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 18, 2024
@debarshiray
test/system: Simplify the line count checks by relying on Bats >= 1.10.0
9f7bfc4 
Commit 87eaeea already added a dependency on Bats >= 1.10.0,
which is present on Fedora >= 39.  Therefore, it should be exploited
wherever possible to simplify things.

containers#1546
@debarshiray debarshiray force-pushed the wip/rishi/test-system-cdi-line-count-checks-bats-1.10 branch from c2af813 to 9f7bfc4 Compare September 18, 2024 20:38
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 18, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/01e28d39effc4bb2901519d307314d80

✔️ unit-test SUCCESS in 5m 39s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 33s
✔️ unit-test-restricted SUCCESS in 5m 48s
✔️ system-test-fedora-rawhide SUCCESS in 1h 46m 22s
✔️ system-test-fedora-40 SUCCESS in 1h 47m 26s
❌ system-test-fedora-39 RETRY_LIMIT in 3m 37s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Sep 19, 2024

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 19, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/97cd7f53f66a4afd9ce2b0ca1c39ce7e

✔️ unit-test SUCCESS in 5m 48s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 29s
✔️ unit-test-restricted SUCCESS in 6m 25s
✔️ system-test-fedora-rawhide SUCCESS in 1h 41m 26s
❌ system-test-fedora-40 TIMED_OUT in 1h 50m 20s
❌ system-test-fedora-39 TIMED_OUT in 1h 50m 23s

@debarshiray
.zuul, test/system: Simplify line count checks by using Bats >= 1.10.0
f2dc3b8 
Commit 87eaeea already added a dependency on Bats >= 1.10.0,
which is present on Fedora >= 39.  Therefore, it should be exploited
wherever possible to simplify things.

Currently, the CI has been frequently timing out on stable Fedora nodes.
So, increase the timeout from 1 hour 50 minutes to 2 hours to avoid
that.

For what it's worth, the timeout for Fedora Rawhide nodes is 2 hours 10
minutes and it seems enough.

containers#1546
@debarshiray debarshiray force-pushed the wip/rishi/test-system-cdi-line-count-checks-bats-1.10 branch from 9f7bfc4 to f2dc3b8 Compare September 19, 2024 11:58
@debarshiray debarshiray changed the title test/system: Simplify the line count checks by relying on Bats >= 1.10.0 .zuul, test/system: Simplify line count checks by using Bats >= 1.10.0 Sep 19, 2024
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 19, 2024

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d145530369ff4e1db265de2b599d977b

✔️ unit-test SUCCESS in 5m 36s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 02s
✔️ unit-test-restricted SUCCESS in 5m 35s
✔️ system-test-fedora-rawhide SUCCESS in 1h 48m 49s
✔️ system-test-fedora-40 SUCCESS in 1h 43m 52s
✔️ system-test-fedora-39 SUCCESS in 1h 48m 53s

@debarshiray debarshiray merged commit f2dc3b8 into containers:main Sep 19, 2024
@debarshiray debarshiray deleted the wip/rishi/test-system-cdi-line-count-checks-bats-1.10 branch September 19, 2024 13:50
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jan 26, 2026
@debarshiray
.zuul: Try to prevent the CI from timing out on Fedora 39 and 40
316a3b1 
Currently, the CI has been frequently timing out on stable Fedora nodes.
So, increase the timeout from 1 hour 50 minutes to 2 hours to avoid
that.

For what it's worth, the timeout for Fedora Rawhide nodes is 2 hours 10
minutes and it seems enough.

containers#1546
containers#1741
(backported from commit f2dc3b8)
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Feb 2, 2026
@debarshiray
.zuul: Try to prevent the CI from timing out on Fedora 39 and 40
31d00d7 
Currently, the CI has been frequently timing out on stable Fedora nodes.
So, increase the timeout from 1 hour 50 minutes to 2 hours to avoid
that.

For what it's worth, the timeout for Fedora Rawhide nodes is 2 hours 10
minutes and it seems enough.

containers#1546
containers#1741
containers#1750
(backported from commit f2dc3b8)
(cherry picked from commit 316a3b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martymichal martymichal Awaiting requested review from martymichal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@debarshiray