Skip to content

pkg/utils, test/system: Retain errors without -v when forwarding to host#1532

Merged
debarshiray merged 2 commits intocontainers:mainfrom
debarshiray:wip/rishi/cmd-forward-stderr-01
Sep 3, 2024
Merged

pkg/utils, test/system: Retain errors without -v when forwarding to host#1532
debarshiray merged 2 commits intocontainers:mainfrom
debarshiray:wip/rishi/cmd-forward-stderr-01

Conversation

@debarshiray
Copy link
Copy Markdown
Member

@debarshiray debarshiray commented Sep 2, 2024 •
edited
Loading

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 2, 2024
@debarshiray
test/system: Simplify the line count checks by relying on Bats >= 1.10.0
f3cee6b 
Fedoras 37 and 38 didn't have Bats 1.10.0.  However, they reached End of
Life on 15th November 2023 and 21st May 2024 respectively, and were
dropped from the CI [1,2].  Fedora 39 is the oldest supported Fedora and
it has Bats 1.10.0.

Therefore, there's no need to retain compatibility with Bats < 1.10.0.

[1] Commit 9c2b5e9
    containers#1418

[2] Commit b684b19
    containers#1527

containers#1532
@debarshiray debarshiray force-pushed the wip/rishi/cmd-forward-stderr-01 branch from c4008ba to f3cee6b Compare September 2, 2024 13:29
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 2, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/1c5aba871a4c4f2ab58b44dbbd5015da

✔️ unit-test SUCCESS in 5m 39s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 42s
✔️ unit-test-restricted SUCCESS in 5m 39s
❌ system-test-fedora-rawhide NODE_FAILURE Node request 200-0007561209 failed in 0s
❌ system-test-fedora-40 NODE_FAILURE Node request 200-0007561210 failed in 0s
❌ system-test-fedora-39 NODE_FAILURE Node request 200-0007561211 failed in 0s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Sep 2, 2024

recheck

@debarshiray debarshiray changed the title [WIP] ... [WIP] pkg/utils, test/system: Retain errors without -v when forwarding to host Sep 2, 2024
@debarshiray debarshiray mentioned this pull request Sep 2, 2024
Closed
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 2, 2024

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/04a7894e8be64777b904147f4b48aeda

✔️ unit-test SUCCESS in 5m 34s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 29s
✔️ unit-test-restricted SUCCESS in 5m 37s
✔️ system-test-fedora-rawhide SUCCESS in 1h 31m 22s
✔️ system-test-fedora-40 SUCCESS in 1h 31m 31s
✔️ system-test-fedora-39 SUCCESS in 1h 33m 50s

@debarshiray
test/system: Simplify the line count checks by relying on Bats >= 1.10.0
87eaeea 
Fedoras 37 and 38 didn't have Bats 1.10.0.  However, they reached End of
Life on 15th November 2023 and 21st May 2024 respectively, and were
dropped from the CI [1,2].  Fedora 39 is the oldest supported Fedora and
it has Bats 1.10.0.

Therefore, there's no need to retain compatibility with Bats < 1.10.0.

[1] Commit 9c2b5e9
    containers#1418

[2] Commit b684b19
    containers#1527

containers#1532
@debarshiray debarshiray force-pushed the wip/rishi/cmd-forward-stderr-01 branch from f3cee6b to 87eaeea Compare September 3, 2024 10:11
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 3, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/7dd3d144758b4dddae0f528c9c12f9b6

❌ unit-test NODE_FAILURE Node request 200-0007561806 failed in 0s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 30s
❌ unit-test-restricted NODE_FAILURE Node request 200-0007561808 failed in 0s
❌ system-test-fedora-rawhide NODE_FAILURE Node request 200-0007561809 failed in 0s
✔️ system-test-fedora-40 SUCCESS in 1h 50m 20s
❌ system-test-fedora-39 TIMED_OUT in 1h 50m 29s

@debarshiray debarshiray changed the title [WIP] pkg/utils, test/system: Retain errors without -v when forwarding to host pkg/utils, test/system: Retain errors without -v when forwarding to host Sep 3, 2024
@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Sep 3, 2024

@danpawlik @TristanCacqueray Any idea why the Fedora Rawhide nodes are reporting NODE_FAILURE ?

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 3, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/b7d070dfadfb42409f7f6f32dc700588

❌ unit-test NODE_FAILURE Node request 200-0007562236 failed in 0s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 32s
❌ unit-test-restricted NODE_FAILURE Node request 200-0007562238 failed in 0s
❌ system-test-fedora-rawhide NODE_FAILURE Node request 200-0007562239 failed in 0s
✔️ system-test-fedora-40 SUCCESS in 1h 27m 19s
✔️ system-test-fedora-39 SUCCESS in 1h 33m 20s

@debarshiray debarshiray force-pushed the wip/rishi/cmd-forward-stderr-01 branch from ddf44d4 to 62fcc09 Compare September 3, 2024 15:02
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 3, 2024

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/b8594b767ce04ad59de1360d9c7900cc

❌ unit-test NODE_FAILURE Node request 200-0007562479 failed in 0s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 31s
❌ unit-test-restricted NODE_FAILURE Node request 200-0007562481 failed in 0s
❌ system-test-fedora-rawhide NODE_FAILURE Node request 200-0007562482 failed in 0s
✔️ system-test-fedora-40 SUCCESS in 1h 30m 30s
✔️ system-test-fedora-39 SUCCESS in 1h 36m 01s

@TristanCacqueray
Copy link
Copy Markdown
Contributor

TristanCacqueray commented Sep 3, 2024 •
edited
Loading

The image appears broken again, from the nodepool logs we see Exception: Timeout connecting to xxx on port 22. It's probably related to a recent outage from our cloud provider. It should be fixed now.

@TristanCacqueray
Copy link
Copy Markdown
Contributor

TristanCacqueray commented Sep 3, 2024

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 3, 2024

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/e275531fc81e49e4aeb639446ea98ef1

✔️ unit-test SUCCESS in 5m 34s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 28s
✔️ unit-test-restricted SUCCESS in 5m 38s
✔️ system-test-fedora-rawhide SUCCESS in 1h 36m 06s
✔️ system-test-fedora-40 SUCCESS in 1h 34m 54s
✔️ system-test-fedora-39 SUCCESS in 1h 35m 56s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Sep 3, 2024

The image appears broken again, from the nodepool logs we see Exception: Timeout connecting to xxx on port 22. It's probably related to a recent outage from our cloud provider. It should be fixed now.

Thanks for checking, @TristanCacqueray !

@debarshiray debarshiray merged commit 62fcc09 into containers:main Sep 3, 2024
@debarshiray debarshiray deleted the wip/rishi/cmd-forward-stderr-01 branch September 3, 2024 21:16
@debarshiray debarshiray mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martymichal martymichal Awaiting requested review from martymichal

@Jmennius Jmennius Awaiting requested review from Jmennius Jmennius is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@debarshiray @TristanCacqueray @martymichal