Skip to content

test/system: Silence SC2154#1378

Merged
debarshiray merged 3 commits intocontainers:mainfrom
debarshiray:wip/rishi/test-system-pull_distro_image-failure
Sep 25, 2023
Merged

test/system: Silence SC2154#1378
debarshiray merged 3 commits intocontainers:mainfrom
debarshiray:wip/rishi/test-system-pull_distro_image-failure

Conversation

@debarshiray
Copy link
Copy Markdown
Member

@debarshiray debarshiray commented Sep 25, 2023

Otherwise https://www.shellcheck.net/ would complain:

  Line 343:
  if [ "$status" -ne 0 ]; then
        ^-----^ SC2154 (warning): status is referenced but not assigned.

See: https://www.shellcheck.net/wiki/SC2154

@debarshiray
test/system: Simplify checking if the image exists or not
0d43d22 
Bats' 'run' helper is not necessary to merely check if a command
succeeded or not [1].  In this case, it's idiomatic to use the command
as the condition for an 'if' branch.

[1] https://bats-core.readthedocs.io/en/stable/writing-tests.html

containers#1378
@debarshiray
test/system: Specify explit return values
574dbc9 
This removes any ambiguities and makes it clear what value is being
returned.

containers#1378
@debarshiray
test/system: Silence SC2154
4362c39 
Otherwise https://www.shellcheck.net/ would complain:
  Line 343:
  if [ "$status" -ne 0 ]; then
        ^-----^ SC2154 (warning): status is referenced but not assigned.

See: https://www.shellcheck.net/wiki/SC2154

containers#1378
@debarshiray debarshiray force-pushed the wip/rishi/test-system-pull_distro_image-failure branch from ccaee74 to 0d43d22 Compare September 25, 2023 16:14
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 25, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/4a4c499af98749d19e8e351782507ec2

✔️ unit-test SUCCESS in 8m 53s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 31s
✔️ unit-test-restricted SUCCESS in 7m 34s
❌ system-test-fedora-rawhide FAILURE in 33m 05s
✔️ system-test-fedora-38 SUCCESS in 25m 06s
✔️ system-test-fedora-37 SUCCESS in 25m 32s

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 25, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/a800fc90637f409da9483c72c8b39b49

✔️ unit-test SUCCESS in 7m 57s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 26s
✔️ unit-test-restricted SUCCESS in 7m 03s
❌ system-test-fedora-rawhide FAILURE in 32m 27s
✔️ system-test-fedora-38 SUCCESS in 23m 40s
✔️ system-test-fedora-37 SUCCESS in 23m 17s

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Sep 25, 2023

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/09a3426e7f434b14ad1fa22cc0440d07

✔️ unit-test SUCCESS in 8m 17s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 28s
✔️ unit-test-restricted SUCCESS in 7m 40s
❌ system-test-fedora-rawhide FAILURE in 33m 19s
✔️ system-test-fedora-38 SUCCESS in 24m 15s
✔️ system-test-fedora-37 SUCCESS in 24m 14s

@debarshiray
Copy link
Copy Markdown
Member Author

debarshiray commented Sep 25, 2023

There are still some test failures on Fedora Rawhide. For example:

fedora-rawhide | not ok 3 help: Run command 'help' in 145ms
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479,
fedora-rawhide | #  in test file test/system/002-help.bats, line 45)
fedora-rawhide | #   `assert_line --index 0 --partial "toolbox(1)"' failed
fedora-rawhide | # /usr/bin/man
fedora-rawhide | #
fedora-rawhide | # -- line does not contain substring --
fedora-rawhide | # index     : 0
fedora-rawhide | # substring : toolbox(1)
fedora-rawhide | # line      : troff:<standard input>:33: warning: cannot select font 'C'
fedora-rawhide | # --

I believe these are because of changes in various other components in Fedora 39, which we need to track down one by one and work out a fix.

In the mean time, I am going to temporarily override these failures.

@debarshiray debarshiray merged commit 4362c39 into containers:main Sep 25, 2023
@debarshiray debarshiray deleted the wip/rishi/test-system-pull_distro_image-failure branch September 25, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martymichal martymichal Awaiting requested review from martymichal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@debarshiray