Skip to content

Bump c/storage to v1.58.0, then v1.59.0-dev#2319

Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
TomSweeneyRedHat:dev/tsweeney/v1.58.0
Apr 15, 2025
Merged

Bump c/storage to v1.58.0, then v1.59.0-dev#2319
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom
TomSweeneyRedHat:dev/tsweeney/v1.58.0

Conversation

@TomSweeneyRedHat
Copy link
Member

The first SIC Vendor Dance step for Podman v5.5.
Bump c/storage to v1.58.0
and then to v1.59.0-dev

The first SIC Vendor Dance step for Podman v5.5.
Bump c/storage to v1.58.0

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Bump the main branch to the next dev version, v1.59.0-dev.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@mheon
Copy link
Member

mheon commented Apr 15, 2025

LGTM

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@TomSweeneyRedHat: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been tested in podman CI. I think we talked about this, we first have to vendor all the latest code into podman (and ideally buildah) and make sure it passes CI before cutting releases.
Otherwise we keep cutting broken versions that potentially break podman, so I really want a full vendor with all the code of main into podman first.

@TomSweeneyRedHat
Copy link
Member Author

I thought we had discussed doing Podman verifications when PRs were being created, and hopefully doing so via an automated CI. I will spin up a PR for this on Podman for this pass of dancing, but something we should discuss.

@TomSweeneyRedHat
Copy link
Member Author

Podman Test PR: containers/podman#25885

@TomSweeneyRedHat
Copy link
Member Author

Happy Green test buttons on the Podman PR, can this be merged please?

@mheon
Copy link
Member

mheon commented Apr 15, 2025

/approve
/lgtm

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, lsm5, mheon, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6daf2ab into containers:main Apr 15, 2025
20 checks passed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/v1.58.0 branch April 16, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants