Skip to content

[crio-1.31] chore(deps): update dependency golangci/golangci-lint to v1.64.8#2294

Merged
saschagrunert merged 1 commit intocontainers:crio-1.31from
QiWang19:update-lint
Mar 28, 2025
Merged

[crio-1.31] chore(deps): update dependency golangci/golangci-lint to v1.64.8#2294
saschagrunert merged 1 commit intocontainers:crio-1.31from
QiWang19:update-lint

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Mar 24, 2025

update dependency golangci/golangci-lint to v1.64.8 to fix lint failure from #2293. Crio 1.31 will need #2293 to get the patch #2129, addressing the overlay configuration issue OCPBUGS-53284.

…v1.64.8

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19 QiWang19 changed the title [crio-1.31] chore(deps): update dependency golangci/golangci-lint to … [crio-1.31] chore(deps): update dependency golangci/golangci-lint to v1.64.8 Mar 24, 2025
@QiWang19 QiWang19 closed this Mar 24, 2025
@QiWang19 QiWang19 reopened this Mar 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

@QiWang19: No presubmit jobs available for containers/storage@crio-1.31

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@QiWang19
Copy link
Member Author

@containers/storage-maintainers could you review this and #2293?

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 25, 2025

@QiWang19 AFAIK the crio-* branches are node-created and node-maintained; historically this one has had only manual commits.

(I’m not expressing any opinion on that process, I’m not even sure it was widely discussed or agreed upon, and right now I can’t research that; I’m just hoping that saying the little I know now might help inform your discussions or next steps. But with KW gone, it’s also possible that we lost the memory/history of this.)

@QiWang19
Copy link
Member Author

@saschagrunert could you review this and #2293?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert merged commit 342aeed into containers:crio-1.31 Mar 28, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants