[crio-1.31] Fix assignment of quota project IDs#2293
Merged
saschagrunert merged 2 commits intocontainers:crio-1.31from Mar 28, 2025
Merged
Conversation
Member
|
the lint fix #2294 |
Member
|
@containers/storage-maintainers could you review. Crio 1.31 need the revert PR #2129 to address the overlay configuration issue OCPBUGS-53284 |
saschagrunert
approved these changes
Mar 28, 2025
Member
|
@QiWang19 do you mind a rebase here? |
This reverts commit f4c8d96. We do actually require the PROJINHERIT flag for proper operation. The trick is that we have to remove it on the top-level directory (which requires having the flag defined). Revert this commit as such. Signed-off-by: Matt Heon <mheon@redhat.com>
Basically, PROJINHERIT causes all lower-level directories to get the same project ID. This is a good thing for the directories that are supposed to have quotas. It is not a nice thing for the top-level directory. We set a project ID on that directory so we know what the base ID is for our subdirectories to use, but we do not want that ID propagated to subdirectories else everything will end up using that single quota ID. Stripping the flag from the top-level directory (if it is present) resolves this. Partial fix for https://issues.redhat.com/browse/RHEL-18038 Full fix also requires Podman changes as we were setting quotas on the incorrect directory. Signed-off-by: Matt Heon <mheon@redhat.com>
577e8d2 to
5404a68
Compare
saschagrunert
approved these changes
Mar 28, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2129
/assign QiWang19