Move pkg/chunked/internal to pkg/chunked/internal/minimal#2196
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Dec 13, 2024
Merged
Move pkg/chunked/internal to pkg/chunked/internal/minimal#2196openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Conversation
affc787 to
a43c58e
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a43c58e to
c6b8f56
Compare
We now have several internal subpackages of pkg/chunked, so delineate more explicitly the parts that should be kept as small as possible because the c/image compression package depends on them. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
c6b8f56 to
5c67136
Compare
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have several
internalsubpackages ofpkg/chunked, so delineate more explicitly the parts that should be kept as small as possible because the c/image compression package depends on them.Should not change behavior.
Previously discussed in #2194 (comment) .
I don’t like the
internal/minimalsubpackage name much; I don’t know how to choose a name that both expresses “be careful not to add dependencies here” and that looks good at the call sites (which don’t all care about the minimizing dependencies). Suggestions for an alternative are very welcome.